-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subpartitioning: Add tests for Transactional Batch #3930
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors|Removes) Description"
Internal should be used for PRs that have no customer impact. This flag is used to help generate the changelog to know which PRs should be included. Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.
public async Task TransactionalBatchTestForSubpartitionedContainer() | ||
{ | ||
string currentVersion = HttpConstants.Versions.CurrentVersion; | ||
HttpConstants.Versions.CurrentVersion = "2020-07-15"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need this?
|
||
ContainerProperties containerProperties = new ContainerProperties("subpartitionedcontainer", new List<string> { "/Country", "/City" }); | ||
Container container = await database.CreateContainerAsync(containerProperties); | ||
ContainerInternal containerInternal = (ContainerInternal)container; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these casts needed? Aren't all the APIs being accessed in the non-internal interface?
@@ -318,4 +318,10 @@ | |||
<data name="FeedToken_InvalidFeedTokenForContainer" xml:space="preserve"> | |||
<value>The continuation was generated for container {0} but current container is {1}.</value> | |||
</data> | |||
<data name="TooFewPartitionKeyComponents" xml:space="preserve"> | |||
<value>PartitionKey has fewer components than defined the collection resource.</value> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"than defined for the container." instead of "than defined the collection resource."
Pull Request Template
Description
Please include a summary of the change and which issue is fixed. Include samples if adding new API, and include relevant motivation and context. List any dependencies that are required for this change.
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber